[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D156363#4545410 <https://reviews.llvm.org/D156363#4545410>, @phosek wrote:

> We see 14 failing tests on our Linux and macOS builders, and 6 failing tests on Windows builders:
>
> - `Clang :: Driver/csky-toolchain.c`
> - `Clang :: Driver/env.c`
> - `Clang :: Driver/fsanitize.c`
> - `Clang :: Driver/gcc-install-dir.cpp`
> - `Clang :: Driver/gcc-toolchain.cpp`
> - `Clang :: Driver/linux-cross.cpp`
> - `Clang :: Driver/linux-ld.c`
> - `Clang :: Driver/loongarch-toolchain.c`
> - `Clang :: Driver/miamcu-opt.c`
> - `Clang :: Driver/nolibc.c`
> - `Clang :: Driver/pic.c`
> - `Clang :: Driver/riscv32-toolchain.c`
> - `Clang :: Driver/riscv64-toolchain.c`
> - `Clang :: OpenMP/linking.c`
>
> Here is an example of failing builds:
>
> - https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8774104426056321089/overview
> - https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8774104252942379969/overview
> - https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b8774107666355415825/overview
> - https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8774105312409650497/overview
>
> Can we please revert this change while this is being investigated?

To the best of my knowledge, no official build exhibits these failures.
These are non-official builds with quite complex builds. In the end I'd say I'd revert the patch, but my reasoning is different from: the patch broke the unofficial bot, so we justify to revert the patch.
It's more on the basis that these tests indicate issues that would likely happen on official build bots, if an official build bot had such coverage.

FWIW: I have tried `-DCLANG_DEFAULT_CXX_STDLIB=libc++ -C clang/cmake/caches/Fuchsia-stage2.cmake -DLLVM_ENABLE_LTO=off` to be similar to your build bots appear to be using (I am unfamiliar with it) but unable to reproduce the failures.

I think we need some assistance from Fuchsia to understand why these tests are less portable and what adjustment is needed to make them more portable.

---

With that said, `clang/test/Driver/fsanitize.c` is broken on some official build bots (e.g. clang-aarch64-sve-vla https://lab.llvm.org/buildbot/#/builders/197/builds/8677) and on http://45.33.8.238/ (I trust much for representing some configurations that an official build bot would cover), so I think a revert is justified, if we don't want to unsupport `clang/test/Driver/fsanitize.c`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363