[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Petr Hosek via Phabricator via cfe-commits]

phosek added a comment.

We see 14 failing tests on our Linux and macOS builders, and 6 failing tests on Windows builders:

- `Clang :: Driver/csky-toolchain.c`
- `Clang :: Driver/env.c`
- `Clang :: Driver/fsanitize.c`
- `Clang :: Driver/gcc-install-dir.cpp`
- `Clang :: Driver/gcc-toolchain.cpp`
- `Clang :: Driver/linux-cross.cpp`
- `Clang :: Driver/linux-ld.c`
- `Clang :: Driver/loongarch-toolchain.c`
- `Clang :: Driver/miamcu-opt.c`
- `Clang :: Driver/nolibc.c`
- `Clang :: Driver/pic.c`
- `Clang :: Driver/riscv32-toolchain.c`
- `Clang :: Driver/riscv64-toolchain.c`
- `Clang :: OpenMP/linking.c`

Here is an example of failing builds:

- https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8774104426056321089/overview
- https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8774104252942379969/overview
- https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b8774107666355415825/overview
- https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8774105312409650497/overview

Can we please revert this change while this is being investigated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363