[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 26 15:44:50 PDT 2023


shafik added inline comments.


================
Comment at: clang/unittests/libclang/LibclangTest.cpp:1232
   ASSERT_TRUE(staticAssertCsr.has_value());
-  size_t argCnt = 0;
+  int argCnt = 0;
   Traverse(*staticAssertCsr, [&argCnt](CXCursor cursor, CXCursor parent) {
----------------
Above you used `0u` but here you changed the type to `int`, is there a reason why not to use `0u` here as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156224/new/

https://reviews.llvm.org/D156224



More information about the cfe-commits mailing list