[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

Tue Jul 25 05:05:36 PDT 2023

kiloalphaindia added a comment.

I had copied the warning-flags from the build-bot command line and ended up as follows:

  -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -Woverloaded-virtual -Wno-nested-anon-types -O2 -DNDEBUG -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -Wno-suggest-override

This obviously includes `-Wextra` ...
Still wondering, why I couldn't see the warning.
Which version of GTEST are you using?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156224/new/

https://reviews.llvm.org/D156224