[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

Tue Jul 25 16:03:20 PDT 2023

MatzeB added a comment.

In D154658#4533476 <https://reviews.llvm.org/D154658#4533476>, @MatzeB wrote:

> This change results in some of our builds (distributed Thin-LTO in case that matters) to fail with missing symbols. At a first glance this seems to emit VTables in some files where it didn't do this before and then fails to resolve some members of that vtable. I'm in the process of analyzing this further and making a small reproducer.

I just noticed b6847edfc235829b37dd6d734ef5bbfa0a58b6fc <https://reviews.llvm.org/rGb6847edfc235829b37dd6d734ef5bbfa0a58b6fc> mentioned in the task above which isn't part of our builds yet. I see even symbols emitted with that change and suspect it may resolves the undefined symbols problems then. Will know for sure in a day or two (and if you hear nothing all is working well).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154658/new/

https://reviews.llvm.org/D154658