[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 16:01:29 PDT 2023


rsmith added a comment.

In D154658#4533476 <https://reviews.llvm.org/D154658#4533476>, @MatzeB wrote:

> This change results in some of our builds (distributed Thin-LTO in case that matters) to fail with missing symbols. At a first glance this seems to emit VTables in some files where it didn't do this before and then fails to resolve some members of that vtable. I'm in the process of analyzing this further and making a small reproducer.

Please try again after rGb6847edfc235829b37dd6d734ef5bbfa0a58b6fc <https://reviews.llvm.org/rGb6847edfc235829b37dd6d734ef5bbfa0a58b6fc> and see if you're still having issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154658/new/

https://reviews.llvm.org/D154658



More information about the cfe-commits mailing list