[PATCH] D155857: [clang] fix nonnull warnings during build

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 10:14:57 PDT 2023


MaskRay added a comment.

I agree with the analysis. My understanding is that we don't worsen the code quality for Clang to work around a GCC warning.
And generally we care strongly about Clang warnings, but less about GCC warnings, especially in `.cpp` files. However, this is in a header and perhaps we should pay some attention, as it may affect Clang library users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155857/new/

https://reviews.llvm.org/D155857



More information about the cfe-commits mailing list