[PATCH] D155857: [clang] fix nonnull warnings during build
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 20 09:31:51 PDT 2023
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
This branch doesn't look necessary or correct to me. We should never call this function on a lazy pointer in offset mode unless we have an external source that produced the offset, and it's certainly not appropriate to cast the offset to a pointer and return it.
Do you have a testcase that is crashing here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155857/new/
https://reviews.llvm.org/D155857
More information about the cfe-commits
mailing list