[PATCH] D155123: [Driver] Warn about -mios-version-min instead of erroring out when targeting MachO embedded architectures

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 12 23:30:04 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/test/Driver/macho-embedded.c:16
 
+// CHECK-MACHO-EMBEDDED-DIAG: clang: warning: argument unused during compilation: '-mios-version-min=5'
 // CHECK-MACHO-EMBEDDED: "-triple" "{{thumbv[67]e?m}}-apple-unknown-macho"
----------------
Without the change, this may fail for some vendors and this is the reason that some tests have `-no-canonical-prefixes` (I have cleaned up a lot). For errors and warnings, we usually don't test the string before `error`/`warning` anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155123/new/

https://reviews.llvm.org/D155123



More information about the cfe-commits mailing list