[PATCH] D155123: [Driver] Warn about -mios-version-min instead of erroring out when targeting MachO embedded architectures

Wed Jul 12 18:15:59 PDT 2023

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.

================
Comment at: clang/test/Driver/macho-embedded.c:9

+// RUN: %clang -arch armv7m -target thumbv7-apple-ios -mios-version-min=5 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-MACHO-EMBEDDED-DIAG --check-prefix=CHECK-MACHO-EMBEDDED
+
----------------
`-target ` is deprecated since Clang 3.4 (274b6f0c87a6a1798de0a68135afc7f95def6277). Use `--target=` for new tests?

`-fdriver-only` may be slightly better than `-###` as `-fdriver-only` causes clang to return with non-zero upon an error, while `-###` doesn't.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155123/new/

https://reviews.llvm.org/D155123