[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

Tue Jul 11 03:21:06 PDT 2023

Hahnfeld added a comment.

In D41416#4487516 <https://reviews.llvm.org/D41416#4487516>, @ChuanqiXu wrote:

> But some local in tree tests got failed. I took some time to investigate them but I didn't get insights :  (

If the failures involve template template parameters, please note that you need https://reviews.llvm.org/D153003 for that to properly hash and find in the list of lazy specializations.

================
Comment at: clang/lib/AST/DeclTemplate.cpp:366
+                                                      Args,
+                                                      TemplateParameterList *TPL) const {
+  CommonBase *CommonBasePtr = getMostRecentDecl()->getCommonPtr();
----------------
ChuanqiXu wrote:
> TPL here looks not used.
This is required because of the argument forwarding from `findSpecializationImpl` below...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41416/new/

https://reviews.llvm.org/D41416