[PATCH] D154093: [clang-format] Break long strings in Verilog

Thu Jul 6 12:22:50 PDT 2023

HazardyKnusperkeks added a comment.

In D154093#4466597 <https://reviews.llvm.org/D154093#4466597>, @sstwcw wrote:

> In D154093#4466246 <https://reviews.llvm.org/D154093#4466246>, @HazardyKnusperkeks wrote:
>
>> I'd really prefer you put what you need to modify `mutable` instead of removing the `const` from everything else. But that's just my opinion.
>
> Why should the `insertBreak` method be const?

Because it shouldn't and up until now doesn't modify the `BreakableToken` the modifying changes happen in the `WhitespaceManager`.

================
Comment at: clang/include/clang/Format/Format.h:1929
+  ///
+  /// For C#, Java, and JavaScript, the developers never got to implementing the
+  /// feature.
----------------
I'd drop that, or replace it with a nicer sentence which only speaks of "all other languages", because right now you are missing at least protobuf and json.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154093/new/

https://reviews.llvm.org/D154093