[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 6 00:22:02 PDT 2023


sdesmalen added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:87-90
+    if (Feature == "sme") {
+      Features.push_back("+sve");
+      Features.push_back("+sve2");
+      Features.push_back("+bf16");
----------------
SME shouldn't require SVE or SVE2. You can see the dependence in AArch64.td. We've updated code in AArch64 target SelectionDAG with `HasSVEorSME` instead of `HasSVE` where needed, so that code can still compile when only using `+sme`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142702/new/

https://reviews.llvm.org/D142702



More information about the cfe-commits mailing list