[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

[Jessica Clarke via Phabricator via cfe-commits]

jrtc27 added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuilder.h:158
 
   /// This method is to be deprecated. Use `Address::withElementType` instead.
+  [[deprecated("Use `Address::withElementType` instead.")]]
----------------
JOE1994 wrote:
> nikic wrote:
> > JOE1994 wrote:
> > > 
> > This is a private method, so simply delete it instead of deprecating.
> It seems like this method is listed as "public" member functions in https://clang.llvm.org/doxygen/classclang_1_1CodeGen_1_1CGBuilderTy.html .
> 
> I see the `public` specifier on line 50.
It's public in the sense of its access specifier, i.e. that it can be used outside of CGBuiltin, but it's private in the sense that this header is in clang/lib/CodeGen and thus only used within Clang itself, not exposed as a Clang API, so if Clang isn't using it any more, nothing is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154285/new/

https://reviews.llvm.org/D154285