[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

Sat Jul 1 13:43:36 PDT 2023

JOE1994 added inline comments.

================
Comment at: clang/lib/CodeGen/CGBuilder.h:158

   /// This method is to be deprecated. Use `Address::withElementType` instead.
+  [[deprecated("Use `Address::withElementType` instead.")]]
----------------
nikic wrote:
> JOE1994 wrote:
> > 
> This is a private method, so simply delete it instead of deprecating.
It seems like this method is listed as "public" member functions in https://clang.llvm.org/doxygen/classclang_1_1CodeGen_1_1CGBuilderTy.html .

I see the `public` specifier on line 50.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154285/new/

https://reviews.llvm.org/D154285