[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:61
+  /// Passing in the same formula will result in the same BoolValue.
+  /// FIXME: This canonicalization isn't sound e.g. if we create two BoolValues
+  ///        with the same formula but attach different properties.
----------------
Per our offline conversation, do you still believe in this fixme?


================
Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:132
+///        When we want to specify atom identity, use Atom.
 class AtomicBoolValue : public BoolValue {
 public:
----------------



================
Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:146
+/// Models a compound boolean formula.
+class FormulaBoolValue : public BoolValue {
 public:
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153469/new/

https://reviews.llvm.org/D153469