[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

Rashmi Mudduluru via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 29 13:03:19 PDT 2023


t-rasmud added inline comments.


================
Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-multi-parm-span.cpp:251
+}
+// CHECK-NOT: fix-it:{{.*}}:{[[@LINE-1]]
----------------
Does this patch handle virtual methods? Ideally we'd like the fixed methods to have the same subtyping relations as the original method. Does it make sense to have test cases with virtual methods as part of this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153059/new/

https://reviews.llvm.org/D153059



More information about the cfe-commits mailing list