[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

[Rashmi Mudduluru via Phabricator via cfe-commits]

t-rasmud added inline comments.


================
Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-multi-parm-span.cpp:5
+
+// FIXME: what about possible diagnostic message non-determinism?
+
----------------
I have used a workaround for non-determinism by using regular expressions to match on the `expected-note`.  See https://github.com/llvm/llvm-project/commit/db3dcedb9cedcec4a9570fda7406490c642df8ae#diff-8486f0b4ae37871fc0a186f40a41adbc70e5a0ca0134dc9bba762e1f17994460R176.
This is definitely a temporary fix (but helps with passing llvm builedbot tests upon landing on `llvm-project\main`) and we should probably discuss and put in a more reliable fix (say, using ordered sets) in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153059/new/

https://reviews.llvm.org/D153059