[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates

Takuya Shimizu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 23 06:28:35 PDT 2023


hazohelet marked an inline comment as done.
hazohelet added inline comments.


================
Comment at: clang/lib/Sema/Sema.cpp:1385
+          Diag(DiagD->getLocation(), diag::warn_unused_template)
+              << /*variable*/ 1 << DiagD;
         } else if (DiagD->getType().isConstQualified()) {
----------------
shafik wrote:
> Sorry for late review but we should conform to [bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html) for these.
Thanks. Fixed in 940c94e1c1b99511630b6f61890ac54161b5829c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152796/new/

https://reviews.llvm.org/D152796



More information about the cfe-commits mailing list