[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates
Shafik Yaghmour via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 21 20:06:19 PDT 2023
shafik added inline comments.
================
Comment at: clang/lib/Sema/Sema.cpp:1385
+ Diag(DiagD->getLocation(), diag::warn_unused_template)
+ << /*variable*/ 1 << DiagD;
} else if (DiagD->getType().isConstQualified()) {
----------------
Sorry for late review but we should conform to [bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html) for these.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152796/new/
https://reviews.llvm.org/D152796
More information about the cfe-commits
mailing list