[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

Wed Jun 21 15:24:31 PDT 2023

smeenai added a comment.

In D153175#4431923 <https://reviews.llvm.org/D153175#4431923>, @hans wrote:

>> -H is supposed to skip outputting headers from -include command line
>> arguments, but -fshow-skipped-includes was outputting any skipped
>> includes encountered via -include.
>
> I was thrown off by the "-H is supposed to skip ... but -fshow-skipped-includes was outputting ..."
>
> I suppose the point is that we do want `-fshow-skipped-includes` to show skipped includes, but not the ones from `-include` or system headers (unless `-sys-header-deps`)?
>
> lgtm if I got that right.

Yup, my description was kinda terrible :D Lemme try to clarify it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153175/new/

https://reviews.llvm.org/D153175