[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 01:22:28 PDT 2023


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

> -H is supposed to skip outputting headers from -include command line
> arguments, but -fshow-skipped-includes was outputting any skipped
> includes encountered via -include.

I was thrown off by the "-H is supposed to skip ... but -fshow-skipped-includes was outputting ..."

I suppose the point is that we do want `-fshow-skipped-includes` to show skipped includes, but not the ones from `-include` or system headers (unless `-sys-header-deps`)?

lgtm if I got that right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153175/new/

https://reviews.llvm.org/D153175



More information about the cfe-commits mailing list