[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

Wed Jun 21 12:30:07 PDT 2023

sbc100 added inline comments.

================
Comment at: llvm/utils/lit/lit/llvm/config.py:347
+            return triple
+
         m = re.match(r"(\w+)-(\w+)-(\w+)", triple)
----------------
dicej wrote:
> sbc100 wrote:
> > Are the the changes to this file meant to be part of this CL?
> The `check-clang` target doesn't work at all if the target "triple" is a double, e.g.:
> 
> ```
> llvm-lit: /Users/dicej/p/wasi-sdk/src/llvm-project/llvm/utils/lit/lit/llvm/config.py:459: note: using clang: /Users/dicej/p/wasi-sdk/build/llvm/bin/clang
> llvm-lit: /Users/dicej/p/wasi-sdk/src/llvm-project/llvm/utils/lit/lit/llvm/config.py:324: fatal: Could not turn 'wasm32-wasi' into Itanium ABI triple
> ```
> 
> @sunfish had been using this patch locally to work around the issue, so I figured I'd include the patch here so it stops being a stumbling block.  Perhaps there's a better way to address it?
Can you split this out into a separate change.. its seem unrelated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153293/new/

https://reviews.llvm.org/D153293