[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

Wed Jun 21 12:10:43 PDT 2023

dicej added a comment.

In D153293#4437877 <https://reviews.llvm.org/D153293#4437877>, @sbc100 wrote:

> In D153293#4437644 <https://reviews.llvm.org/D153293#4437644>, @dicej wrote:
>
>> In D153293#4436629 <https://reviews.llvm.org/D153293#4436629>, @sbc100 wrote:
>>
>>> I'm happy to merge it, but perhaps we should get @sunfish to lg too.
>>>
>>> Also, should we remove the `-experimental-pic` linker flag, or are you OK with that warning from the linker?   If yes, I wonder if we should do that as part of this CL or a followup?
>>
>> Do `emscripten` users see that warning, too?  I'd like to match whatever they see (or don't see).
>
> No, the emscripten driver (emcc) currently adds `--experimental-pic` to the linker flags to avoid this warning.  We could gladly remove that if it becomes the default.

OK; I'd say let's leave the warning there since this feature so new for non-emscripten targets.  We can come back and remove it later on once things have settled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153293/new/

https://reviews.llvm.org/D153293