[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics
Nuno Lopes via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 20 07:17:46 PDT 2023
nlopes added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:213
+
+ Value *Result = UndefValue::get(Ty);
+ for (int i = 0; i < EC; i += 1 + is16Bit) {
----------------
Please use poison wherever possible. In this case it seems it's just a placeholder, so it can be poison.
We're trying to get rid of poison. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147732/new/
https://reviews.llvm.org/D147732
More information about the cfe-commits
mailing list