[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

[Yueh-Ting (eop) Chen via Phabricator via cfe-commits]

eopXD added a comment.

In D152070#4425378 <https://reviews.llvm.org/D152070#4425378>, @rogfer01 wrote:

> In D152070#4425358 <https://reviews.llvm.org/D152070#4425358>, @eopXD wrote:
>
>> In D152070#4425318 <https://reviews.llvm.org/D152070#4425318>, @rogfer01 wrote:
>>
>>> In D152070#4421004 <https://reviews.llvm.org/D152070#4421004>, @DavidSpickett wrote:
>>>
>>>> FYI after this change:
>>>>
>>>>   Building CXX object tools/lldb/sou...luginTypeSystemClang.dir/TypeSystemClang.cpp.o
>>>>   /home/david.spickett/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4843:13: warning: 225 enumeration values not handled in switch: 'RvvInt8mf8x2', 'RvvInt8mf8x3', 'RvvInt8mf8x4'... [-Wswitch]
>>>>       switch (llvm::cast<clang::BuiltinType>(qual_type)->getKind()) {
>>>>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>
>>>> lldb doesn't do anything with RVV yet, so you can likely just add all the names to the existing block of RVV stuff that just `break`s at the end.
>>>
>>> This might be the cause to a crash I'm observing and that bisect pointed to.
>>>
>>> Reproducer:
>>>
>>>   $ touch t.c # empty file
>>>   $ clang -cc1 -triple riscv64 -w -emit-pch -o test.pch t.c
>>>   $ clang -cc1 -triple riscv64 -w -x c -include-pch test.pch -ast-dump-all /dev/null
>>
>> Warning (and possibly the error you got) should be fixed now through https://reviews.llvm.org/D152922.
>
> Sorry @eopXD I confused everyone by linking the clang issue with that of lldb and they are unrelated. Apologies.
>
> Can you check if clang crashes for you?

I am seeing messages related to builtin type, but they do not seem related to RVV builtin types.

  $ touch t.c
  $ clang -cc1 -triple riscv64 -w -emit-pch -o test.pch t.c
  $ clang -cc1 -triple riscv64 -w -x c -include-pch test.pch -ast-dump-all /dev/null
  TranslationUnitDecl 0x60f3f88 <<invalid sloc>> <invalid sloc> <undeserialized declarations>
  |-TypedefDecl 0x60f4b78 <<invalid sloc>> <invalid sloc> implicit __int128_t '__int128'
  | `-BuiltinType 0x60f4520 '__int128'
  |-TypedefDecl 0x60f4be8 <<invalid sloc>> <invalid sloc> implicit __uint128_t 'unsigned __int128'
  | `-BuiltinType 0x60f4540 'unsigned __int128'
  |-TypedefDecl 0x60f4ae8 <<invalid sloc>> <invalid sloc> implicit __NSConstantString 'struct __NSConstantString_tag'
  | `-RecordType 0x60f48c0 'struct __NSConstantString_tag' imported
  |   `-Record 0x60f4828 '__NSConstantString_tag'
  `-TypedefDecl 0x60f4c58 <<invalid sloc>> <invalid sloc> implicit __builtin_va_list 'void *'
    `-PointerType 0x60f47a0 'void *'
      `-BuiltinType 0x60f3fe0 'void'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152070/new/

https://reviews.llvm.org/D152070