[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

Roger Ferrer Ibanez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 09:59:05 PDT 2023


rogfer01 added a comment.

In D152070#4425358 <https://reviews.llvm.org/D152070#4425358>, @eopXD wrote:

> In D152070#4425318 <https://reviews.llvm.org/D152070#4425318>, @rogfer01 wrote:
>
>> In D152070#4421004 <https://reviews.llvm.org/D152070#4421004>, @DavidSpickett wrote:
>>
>>> FYI after this change:
>>>
>>>   Building CXX object tools/lldb/sou...luginTypeSystemClang.dir/TypeSystemClang.cpp.o
>>>   /home/david.spickett/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4843:13: warning: 225 enumeration values not handled in switch: 'RvvInt8mf8x2', 'RvvInt8mf8x3', 'RvvInt8mf8x4'... [-Wswitch]
>>>       switch (llvm::cast<clang::BuiltinType>(qual_type)->getKind()) {
>>>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> lldb doesn't do anything with RVV yet, so you can likely just add all the names to the existing block of RVV stuff that just `break`s at the end.
>>
>> This might be the cause to a crash I'm observing and that bisect pointed to.
>>
>> Reproducer:
>>
>>   $ touch t.c # empty file
>>   $ clang -cc1 -triple riscv64 -w -emit-pch -o test.pch t.c
>>   $ clang -cc1 -triple riscv64 -w -x c -include-pch test.pch -ast-dump-all /dev/null
>
> Warning (and possibly the error you got) should be fixed now through https://reviews.llvm.org/D152922.

Sorry @eopXD I confused everyone by linking the clang issue with that of lldb and they are unrelated. Apologies.

Can you check if clang crashes for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152070/new/

https://reviews.llvm.org/D152070



More information about the cfe-commits mailing list