[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 11 15:30:06 PDT 2023


MaskRay added a comment.

> This option has undergone several refactorings and got inverted along the way. The XRayOmitFunctionIndex flag governs codegen behavior, *omitting* "xray_fn_idx" section if it is set. But the command-line flag behavior was not adjusted at the time. Right now it's like this:

d8a8e5d6240a1db809cd95106910358e69bbf299 <https://reviews.llvm.org/rGd8a8e5d6240a1db809cd95106910358e69bbf299> accidentally omitted `xray_fn_idx` by default.
I pushed 849f1dd15e92fda2b83dbb6144e6b28b2cb946e0 <https://reviews.llvm.org/rG849f1dd15e92fda2b83dbb6144e6b28b2cb946e0> to rename the confusing `XRayOmitFunctionIndex` and fix -fno-xray-function-index/-fxray-function-index.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145848/new/

https://reviews.llvm.org/D145848



More information about the cfe-commits mailing list