[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/test/CodeGen/xray-function-index.cpp:1
+// REQUIRES: x86-registered-target
+// RUN: %clang_cc1 -fxray-instrument                          -x c++ -std=c++11 -triple x86_64-unknown-linux-gnu -S -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-ENABLED
----------------
We generally want to avoid assembly output tests in clang/test.

However, `CodeGenOpts.XRayOmitFunctionIndex` only affects `llvm::TargetOptions`, not LLVM IR, so I think this seems fine.

(Note: a lot of xray tests do not follow the best practice, and we should be careful for new tests, not necessarily copying the old xray testing practice.)


================
Comment at: clang/test/CodeGen/xray-function-index.cpp:2
+// REQUIRES: x86-registered-target
+// RUN: %clang_cc1 -fxray-instrument                          -x c++ -std=c++11 -triple x86_64-unknown-linux-gnu -S -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-ENABLED
+// RUN: %clang_cc1 -fxray-instrument -fno-xray-function-index -x c++ -std=c++11 -triple x86_64-unknown-linux-gnu -S -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-DISABLED
----------------
We don't usually do `           ` alignment  like this. You may place `-S` earlier to make the compile action (emit assembly) clearer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145848/new/

https://reviews.llvm.org/D145848