[PATCH] D143075: BareMetal ToolChain multilib layering

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 22:53:44 PDT 2023


phosek added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246
+  // No multilibs selected so return a single default multilib.
+  static llvm::SmallVector<Multilib> Default = {Multilib()};
+  return llvm::iterator_range<
+      llvm::SmallVector<Multilib>::const_reverse_iterator>(Default.rbegin(),
+                                                           Default.rend());
----------------
What's the reason for returning an empty `Multilib`, could we instead return and empty range?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143075/new/

https://reviews.llvm.org/D143075



More information about the cfe-commits mailing list