[PATCH] D143075: BareMetal ToolChain multilib layering

Michael Platings via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 13:27:48 PDT 2023


michaelplatings added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228
+
+llvm::SmallVector<Multilib> BareMetal::getOrderedMultilibs() const {
+  // Get multilibs in reverse order because they're ordered most-specific last.
----------------
phosek wrote:
> Can you use [llvm::reverse](https://github.com/llvm/llvm-project/blob/1d8820c342560a2fbf8e1970b861193ba8137177/llvm/include/llvm/ADT/STLExtras.h#L511) instead of allocating an entire new collection?
Changed to return an iterator range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143075/new/

https://reviews.llvm.org/D143075



More information about the cfe-commits mailing list