[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)

Thu Jun 1 10:29:59 PDT 2023

jansvoboda11 added inline comments.

================
Comment at: clang/include/clang/Lex/HeaderSearch.h:763
   ///         find this file due to requirements from \p RequestingModule.
-  bool findUsableModuleForHeader(const FileEntry *File,
+  bool findUsableModuleForHeader(OptionalFileEntryRef File,
                                  const DirectoryEntry *Root,
----------------
benlangmuir wrote:
> This should probably be non-Optional. I can't find any calls to this API that can pass null, they all pass something that is already being dereferenced.
You're right, thanks. Fixed in the committed version.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151854/new/

https://reviews.llvm.org/D151854