[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)
Ben Langmuir via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 1 09:31:38 PDT 2023
benlangmuir added a comment.
================
Comment at: clang/include/clang/Lex/HeaderSearch.h:763
/// find this file due to requirements from \p RequestingModule.
- bool findUsableModuleForHeader(const FileEntry *File,
+ bool findUsableModuleForHeader(OptionalFileEntryRef File,
const DirectoryEntry *Root,
----------------
This should probably be non-Optional. I can't find any calls to this API that can pass null, they all pass something that is already being dereferenced.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151854/new/
https://reviews.llvm.org/D151854
More information about the cfe-commits
mailing list