[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

[Alex Voicu via Phabricator via cfe-commits]

AlexVlx added a comment.

In D150746#4381758 <https://reviews.llvm.org/D150746#4381758>, @rjmccall wrote:

> The process is pretty lightweight; I'd recommend just doing it if you expect to make more than one patch.  But we don't have a policy against committing patches for other people as long as there's clear attribution in the commit.
>
> I do think you could successfully test the basic code patterns with passing VTT arguments.  Your test is solely testing that these constructors and destructors are being declared with the right signature, but it doesn't test any calls to them.

Thanks, I've sorted the commit access since this (and some associated work) will entail multiple patches. I would like to clarify the second point to make sure that I'm incorporating that suggestion - the checks on lines 25, 26 & 27 are for actual calls - since now the signature matches the VTT type there's no arg setup prior to the call, it's a direct passing of the global. Were you thinking about something else here / am I missing somethign obvious?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150746/new/

https://reviews.llvm.org/D150746