[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 30 11:19:36 PDT 2023


rjmccall added a comment.

The process is pretty lightweight; I'd recommend just doing it if you expect to make more than one patch.  But we don't have a policy against committing patches for other people as long as there's clear attribution in the commit.

I do think you could successfully test the basic code patterns with passing VTT arguments.  Your test is solely testing that these constructors and destructors are being declared with the right signature, but it doesn't test any calls to them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150746/new/

https://reviews.llvm.org/D150746



More information about the cfe-commits mailing list