[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added inline comments.


================
Comment at: clang/include/clang/Basic/Module.h:160
+  llvm::PointerUnion<const FileEntryRef::MapEntry *,
+                     const DirectoryEntryRef::MapEntry *>
       Umbrella;
----------------
benlangmuir wrote:
> Would it make sense to implement `PointerLikeTypeTraits` for FileEntryRef/DirectoryEntryRef so you don't need to use the MapEntry explicitly?
It would. I'll do that in a follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151584/new/

https://reviews.llvm.org/D151584