[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir accepted this revision.
benlangmuir added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Basic/Module.h:160
+  llvm::PointerUnion<const FileEntryRef::MapEntry *,
+                     const DirectoryEntryRef::MapEntry *>
       Umbrella;
----------------
Would it make sense to implement `PointerLikeTypeTraits` for FileEntryRef/DirectoryEntryRef so you don't need to use the MapEntry explicitly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151584/new/

https://reviews.llvm.org/D151584