[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 20 13:52:20 PDT 2023


owenpan added a comment.

In D150403#4350325 <https://reviews.llvm.org/D150403#4350325>, @galenelias wrote:

> In D150403#4347323 <https://reviews.llvm.org/D150403#4347323>, @HazardyKnusperkeks wrote:
>
>> We'll wait a bit, if someone might have a comment. And (at least I) need name and email for the commit.
>
> Name: Galen Elias
> Email: galenelias at gmail dot com

Can you put your authorship in the 'John Doe <jdoe at llvm.org>' <https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator> format?

In D150403#4358562 <https://reviews.llvm.org/D150403#4358562>, @rymiel wrote:

> This patch also fixes https://github.com/llvm/llvm-project/issues/52911 (which is probably a duplicate anyway)

@galenelias Can you update the summary?



================
Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1789-1790
+TEST_F(TokenAnnotatorTest, UnderstandsNestedBlocks) {
+  // The closing braces are not annotated.  It doesn't seem to cause a
+  // problem.  So we only test for the opening braces.
+  auto Tokens = annotate("{\n"
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150403/new/

https://reviews.llvm.org/D150403



More information about the cfe-commits mailing list