[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

Emilia Kond via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 20 05:30:19 PDT 2023


rymiel added a comment.

This patch also fixes https://github.com/llvm/llvm-project/issues/52911 (which is probably a duplicate anyway)



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:583-584
+              ProbablyBracedList ||
+              NextTok->is(tok::l_brace) && LBraceStack.back().PrevTok &&
+                  LBraceStack.back().PrevTok->is(tok::identifier);
 
----------------
    llvm-project/clang/lib/Format/UnwrappedLineParser.cpp:583:71: warning: '&&' within '||' [-Wlogical-op-parentheses]
              NextTok->is(tok::l_brace) && LBraceStack.back().PrevTok &&
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
    llvm-project/clang/lib/Format/UnwrappedLineParser.cpp:583:71: note: place parentheses around the '&&' expression to silence this warning
              NextTok->is(tok::l_brace) && LBraceStack.back().PrevTok &&
                                                                      ^
              (
1 warning generated.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150403/new/

https://reviews.llvm.org/D150403



More information about the cfe-commits mailing list