[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 19 13:08:31 PDT 2023


rjmccall added a comment.

It's well-formed as IR, just not semantically valid, right?  As long as it's not actually crashing in the verifier, please test as much as you reasonably can that's correct, like that the constructor and destructor functions take something in the right address space, and that calls to them pass a valid VTT.  And then yeah, when you pull a v-table out and try to assign it, that much will be incorrect until your next fix, but that's okay.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150746/new/

https://reviews.llvm.org/D150746



More information about the cfe-commits mailing list