[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

[Alex Voicu via Phabricator via cfe-commits]

AlexVlx added a comment.

In D150746#4354742 <https://reviews.llvm.org/D150746#4354742>, @rjmccall wrote:

> Can you add a test?  I think we have some in-tree targets which put globals in a non-default address space.

I've added the test (think we, i.e. AMDGPU, are the only ones doing this at the moment; both SPIRV & PTX use generic, and I've not checked DXIL since it doesn't seem like a target for this use case), but I'd like to suggest that we keep it disabled until I fix the other parts of handling this (vtables & vptrs), since as it is it will just produce invalid bitcasts in the IR. Would that be acceptable? Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150746/new/

https://reviews.llvm.org/D150746