[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D148505#4356951 <https://reviews.llvm.org/D148505#4356951>, @erichkeane wrote:

> I'm still on the fence.  I think properly documenting all of this entire attribute would make me more comfortable here, particularly since it will allow GCC to follow us easily some day.  I think that would move the needle for me.

I think I've got a slightly different idea there: let's add a new documentation section for all of the related attributes in this area and document (or update) all of them in a block. This way, users have a good way to answer "which one do I use in what circumstance?" as well as other compiler devs who want to match our behavior. I think if we can make the documentation sufficiently clear, then this is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148505/new/

https://reviews.llvm.org/D148505