[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

I'm still on the fence.  I think properly documenting all of this entire attribute would make me more comfortable here, particularly since it will allow GCC to follow us easily some day.  I think that would move the needle for me.



================
Comment at: clang/include/clang/Basic/Attr.td:2997
+  let Subjects = SubjectList<[Record, CXXConstructor]>;
   let Documentation = [Undocumented];
   let SimpleHandler = 1;
----------------
For this to go through, I think we'd want this properly documented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148505/new/

https://reviews.llvm.org/D148505