[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 11:38:00 PDT 2023


jyknight added a comment.

When looking for errors in existing codebases, don't forget that this diagnostic is currently suppressed by default in system headers. So this patch is moving from "no diagnostics for code in system headers" to "unconditional hard error in system headers". Just removing `-Wno-enum-constexpr-conversion` from your build flags is insufficient to test that this patch won't break code!

I haven't done any tests, but I'm rather skeptical that this change is going to be viable without breaking stuff, still.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150226/new/

https://reviews.llvm.org/D150226



More information about the cfe-commits mailing list