[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

Jordan Rupprecht via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 17 10:41:22 PDT 2023


rupprecht added a comment.

In D150226#4338264 <https://reviews.llvm.org/D150226#4338264>, @shafik wrote:

> In D150226#4336755 <https://reviews.llvm.org/D150226#4336755>, @rupprecht wrote:
>
>> We're still using `-Wno-enum-constexpr-conversion`, although I'm not sure if we need that or if we just forgot to remove it after doing some cleanup. I'm trying it out now. (Sorry, I'm not sure we were aware that having a way to turn this off was just temporary).
>
> Please let me know how things look on your end.

It's not that bad, and all remaining breakages have fixes sent out now, but still waiting to land. A week or two is probably good enough for us. But I don't know about the rest of OSS mentioned in other comments.

(FYI, I'll be out for a few weeks, and I might not have a chance to follow up before then)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150226/new/

https://reviews.llvm.org/D150226



More information about the cfe-commits mailing list