[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

[Roy Sundahl via Phabricator via cfe-commits]

rsundahl marked an inline comment as done.
rsundahl added inline comments.


================
Comment at: compiler-rt/docs/ASanABI.rst:29
+
+  Following are some examples of reasonable responses to such changes:
+
----------------
MaskRay wrote:
> How does the 2-space indentation render in the built HTML? It may look good, I ask just in case.
> How does the 2-space indentation render in the built HTML? It may look good, I ask just in case.

IDK so I played around with it. Global search/replace 2 spaces with 4 does not affect rendering of the block above at all. In the block below there was an effect which was to indent the code blocks one more stop. The reason for this seems to be that the "current indent level" is advanced by 2 in a bulleted list, so below, the code block statement is actually aligned with the bulleted paragraph above it. After the GSR, the code block is indented and rendered further indented. Since bullets advance the "current indent level" by 2, maybe a more natural indent for the source code (.rst) is to use 2 as well. Seems to read a little easier in the source and avoids having to think about all the multiple of 4's after a bullet being "off by 2".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143675/new/

https://reviews.llvm.org/D143675