[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/docs/ASanABI.rst:29
+
+  Following are some examples of reasonable responses to such changes:
+
----------------
How does the 2-space indentation render in the built HTML? It may look good, I ask just in case.


================
Comment at: compiler-rt/lib/asan_abi/asan_abi.h:18
+// Functions concerning instrumented global variables:
+void __asan_abi_register_image_globals(void);
+void __asan_abi_unregister_image_globals(void);
----------------
`asan_abi.h` is C++ only (`extern "C"` isn't allowed in C). `(void)` should be replaced with `()`.


================
Comment at: compiler-rt/lib/asan_abi/asan_abi_shim.cpp:14
+extern "C" {
+// Functions concerning instrumented global variables:
+void __asan_register_image_globals(uptr *flag) {
----------------
Below there is no `:`. You may omit this `:` as well.


================
Comment at: compiler-rt/lib/asan_abi/asan_abi_shim.cpp:345
+// Functions concerning fake stacks
+void *__asan_get_current_fake_stack(void) {
+  // TBD: Fail here
----------------



================
Comment at: compiler-rt/test/asan_abi/lit.cfg.py:13
+    lit_config.fatal(
+      "No attribute %r in test configuration! You may need to run "
+      "tests from your build directory or add this attribute "
----------------
This file mixes single quotes and double quotes (the file it copied from does so as well). Pick one and be consistent!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143675/new/

https://reviews.llvm.org/D143675