[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 11 02:14:46 PDT 2023


MyDeveloperDay added inline comments.


================
Comment at: clang/unittests/Format/ObjCPropertyAttributeOrderFixerTest.cpp:77
+  verifyFormat("@property(a, b, c) int p;", "@property(b, a, c) int p;", Style);
+  verifyFormat("@property(a, b, c) int p;", "@property(c, b, a) int p;", Style);
+}
----------------
might it be a good idea to actually test some/all of the keywords you intend to support? just incase some of them are not actually tok::identifiers?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150083/new/

https://reviews.llvm.org/D150083



More information about the cfe-commits mailing list