[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

Interesting



================
Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:69
+      // Ignore the comma separators.
+      continue;
+    } else if (Tok->isOneOf(tok::identifier, tok::kw_class)) {
----------------
You need a unit tests  that tests all the keywords or if one becomes a non identifier then it will break


================
Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:70
+      continue;
+    } else if (Tok->isOneOf(tok::identifier, tok::kw_class)) {
+      // Memoize the attribute. (Note that 'class' is a legal attribute!)
----------------
Make a function, isAttribute()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150083/new/

https://reviews.llvm.org/D150083