[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

> Okay, so I did add that in TokenKinds.h. Isn't that the right place for it? The same way it's done for the other builtins? And in TokenKinds.def I added the lines for the interesting identifiers?

What you're doing in `TokenKinds.{def,h}` seems fine.  What I'm objecting to is adding another field to `IdentifierInfo` to store it instead of fitting it into `ObjCOrBuiltinID`.  Currently an given identifier is either normal, an ObjC keyword, or a builtin ID, and it determines this by checking what range of values ObjCOrBuiltinID fits into.  You can use the same idea to allow an identifier to be either normal, an ObjC keyword, a builtin ID, or an interesting.



================
Comment at: clang/include/clang/Basic/TokenKinds.def:89
+#ifndef Interesting_Identifier
+#define Interesting_Identifier(X)
+#endif
----------------
Please follow the existing pattern by spelling this INTERESTING_IDENTIFIER.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146148/new/

https://reviews.llvm.org/D146148